-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(source): use the default_provider for AWS-related connectors #17933
Conversation
#11086 We had an issue about this. Do we have a discussion context about why allowing this now? |
Yes. See the background https://risingwave-labs.slack.com/archives/C03L8DNMDDW/p1722922448614259?thread_ts=1722281609.938729&cid=C03L8DNMDDW
|
@@ -46,6 +46,10 @@ pub const PRIVATE_LINK_TARGETS_KEY: &str = "privatelink.targets"; | |||
|
|||
const AWS_MSK_IAM_AUTH: &str = "AWS_MSK_IAM"; | |||
|
|||
/// The environment variable to disable using default credential from environment. | |||
/// It's recommended to set this variable to `false` in cloud hosting environment. | |||
const DISABLE_DEFAULT_CREDENTIAL: &str = "DISABLE_DEFAULT_CREDENTIAL"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall it affect services from cloud vendors besides AWS as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the idea looks good to you, I'll add the support of Azure/GCP in future PRs. This PR was supposed to complete #17851
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…7933) Co-authored-by: Phil Sheets <p.sheets@fetchrewards.com> Co-authored-by: psheets <4058236+psheets@users.noreply.github.com>
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
See background at #17851
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.